Skip to content

Unfucks bos armor + recipe RCA fix#357

Open
Osmos123 wants to merge 6 commits intoFoundation-19:masterfrom
Osmos123:unfucksBOS
Open

Unfucks bos armor + recipe RCA fix#357
Osmos123 wants to merge 6 commits intoFoundation-19:masterfrom
Osmos123:unfucksBOS

Conversation

@Osmos123
Copy link
Contributor

About The Pull Request

I took a look at the values of the Knight/Sarge/Knight-Captain combat armors and they are straight up downgrade compared to the ones you find. The fact that you get the crafting recipes to convert combat armor to your fractions combat armor which straight up destroys the armor values makes no sense to me. Right now the changes to the armor are now 1:1 equivalent with regular and reinforced combat armor. Also fixed a recipe that allowed normal combat armor to be changed to reinforced and fixes the naming. Knight and Sarge knight slots are reduced in consideration that they have near end-game armor now. Initiate slots unchanged and they now have downgraded combat armor with the incentive to find more combat armor to convert. Conversion cost decreased to more reasonable values also considering they are just 1:1 now.

image image

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
balance: Makes BOS combat armor 1:1 equivalent to the respective normal and reinforced combat armors. Reduces the BOS Knight slots from 5 > 2 and Knight Sarge 2 > 1. Initiates now have initiate armor instead of knight armor.
tweak: Reduces the cost of the conversion recipes for combat armor
fix: Fixes the reinforced combat armor conversion recipe.
spellcheck: Makes the reinforced combat armor recipe names clearer, fixes typo in armor description
/:cl:

@Aurrain Aurrain added the balance This PR messes with the general balance of the game label Jan 21, 2026
@Aurrain
Copy link
Contributor

Aurrain commented Jan 21, 2026

I believe the BOS combat armors suffered because they were among the earliest sets to be balanced, and after further testing must have been forgotten somehow. Good catch, will test-merge once some fixes are made.

@Aurrain
Copy link
Contributor

Aurrain commented Jan 21, 2026

This PR has a few issues with type paths,
it also bricks the interactions with vendors that sell the BOS-related suits:

code/modules/jobs/job_types/bos.dm:859:error:` /obj/item/clothing/suit/armor/medium/combat/brotherhood/senior: undefined type path
code/modules/jobs/job_types/bos.dm:866:error: /obj/item/clothing/head/helmet/f13/combat/brotherhood/senior: undefined type path
code/datums/components/crafting/recipes/recipes_tailoring.dm:224:error: /obj/item/clothing/suit/armor/medium/combat/brotherhood/initiate/mk2: undefined type path
code/datums/components/crafting/recipes/recipes_tailoring.dm:235:error: /obj/item/clothing/head/helmet/f13/combat/brotherhood/initiate/mk2: undefined type path
code/modules/WVM/wmv_buyer.dm:268:error: /obj/item/clothing/suit/armor/medium/combat/brotherhood/senior: undefined type path
code/modules/WVM/wmv_buyer.dm:269:error: /obj/item/clothing/head/helmet/f13/combat/brotherhood/senior: undefined type path
code/modules/WVM/wmv_buyer.dm:280:error: /obj/item/clothing/suit/armor/medium/combat/brotherhood/captain: undefined type path
code/modules/WVM/wmv_buyer.dm:282:error: /obj/item/clothing/head/helmet/f13/combat/brotherhood/captain: undefined type path

@Aurrain Aurrain added the bug Something isn't working label Jan 21, 2026
@Randumb-Phantomb
Copy link
Contributor

Randumb-Phantomb commented Jan 25, 2026

Reduces the BOS Knight slots from 5 > 2 and Knight Sarge 2 > 1.

Why the slot nerf?

@conradwuzherekekw
Copy link

Reduces the BOS Knight slots from 5 > 2 and Knight Sarge 2 > 1.

Why the slot nerf?

because this is now a faction with roundstart CA due to how the conversion works. it makes BOS armour, which means its what you spawn in with

@Randumb-Phantomb
Copy link
Contributor

Reduces the BOS Knight slots from 5 > 2 and Knight Sarge 2 > 1.

Why the slot nerf?

because this is now a faction with roundstart CA due to how the conversion works. it makes BOS armour, which means its what you spawn in with

Uh, yeah, it's the brotherhood of steel, they already have like half the slots of the other two big factions.

@BobNewman-max
Copy link
Contributor

reminder here to fix the PR so it can be TMed, as soon as it's fixed I will TM it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

balance This PR messes with the general balance of the game bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants