Unfucks bos armor + recipe RCA fix#357
Unfucks bos armor + recipe RCA fix#357Osmos123 wants to merge 6 commits intoFoundation-19:masterfrom
Conversation
|
I believe the BOS combat armors suffered because they were among the earliest sets to be balanced, and after further testing must have been forgotten somehow. Good catch, will test-merge once some fixes are made. |
|
This PR has a few issues with type paths, |
Why the slot nerf? |
because this is now a faction with roundstart CA due to how the conversion works. it makes BOS armour, which means its what you spawn in with |
Uh, yeah, it's the brotherhood of steel, they already have like half the slots of the other two big factions. |
|
reminder here to fix the PR so it can be TMed, as soon as it's fixed I will TM it. |
About The Pull Request
I took a look at the values of the Knight/Sarge/Knight-Captain combat armors and they are straight up downgrade compared to the ones you find. The fact that you get the crafting recipes to convert combat armor to your fractions combat armor which straight up destroys the armor values makes no sense to me. Right now the changes to the armor are now 1:1 equivalent with regular and reinforced combat armor. Also fixed a recipe that allowed normal combat armor to be changed to reinforced and fixes the naming. Knight and Sarge knight slots are reduced in consideration that they have near end-game armor now. Initiate slots unchanged and they now have downgraded combat armor with the incentive to find more combat armor to convert. Conversion cost decreased to more reasonable values also considering they are just 1:1 now.
Pre-Merge Checklist
Changelog
🆑
balance: Makes BOS combat armor 1:1 equivalent to the respective normal and reinforced combat armors. Reduces the BOS Knight slots from 5 > 2 and Knight Sarge 2 > 1. Initiates now have initiate armor instead of knight armor.
tweak: Reduces the cost of the conversion recipes for combat armor
fix: Fixes the reinforced combat armor conversion recipe.
spellcheck: Makes the reinforced combat armor recipe names clearer, fixes typo in armor description
/:cl: